Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Dec 11, 2023

Clean backport to improve relocation density.

Additional testing:

  • Linux AArch64 server fastdebug, tier{1,2,3,4}

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8283626 needs maintainer approval

Issue

  • JDK-8283626: AArch64: Set relocInfo::offset_unit to 4 (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2040/head:pull/2040
$ git checkout pull/2040

Update a local copy of the PR:
$ git checkout pull/2040
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2040/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2040

View PR using the GUI difftool:
$ git pr show -t 2040

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2040.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ab17f88f6ccd793b718394987f868322a2cc0d1f 8283626: AArch64: Set relocInfo::offset_unit to 4 Dec 11, 2023
@openjdk
Copy link

openjdk bot commented Dec 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 11, 2023
@shipilev shipilev marked this pull request as ready for review December 12, 2023 11:38
@shipilev
Copy link
Member Author

/approval request Improves relocInfo offsets range, reduces the need for filler records, and thus improves code density. Applies cleanly. Testing passes.

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@shipilev
8283626: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 12, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283626: AArch64: Set relocInfo::offset_unit to 4

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 43d15d1: 8307926: Support byte-sized atomic bitset operations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 15, 2023
@shipilev
Copy link
Member Author

shipilev commented Jan 3, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

Going to push as commit 21171d9.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 3eb15b0: 8205076: [17u] Inet6AddressImpl.c: lookupIfLocalHost accesses int InetAddress.preferIPv6Address as a boolean
  • 2a0d0ac: 8318183: C2: VM may crash after hitting node limit
  • 53211e0: 8318961: increase javacserver connection timeout values and max retry attempts
  • 5d86e19: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • 43d15d1: 8307926: Support byte-sized atomic bitset operations

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2024
@openjdk openjdk bot closed this Jan 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@shipilev Pushed as commit 21171d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant